Repository navigation
feat: separate the map and constraints workflows (phase 6.1) - #137
Merged
Merged
Conversation
With "Interpolate surfaces from constraints", the build now uses only the features that the user adds in step 4. The column, the contacts and the fault traces keep their data, but the model does not use it. - The model manager has the workflow mode. update_model and refresh_feature_data skip the column and the fault traces, and a column or topology change does not make the model stale. - The data manager does not watch or check the map layers in this mode. - The geology and structure layer checks move to the stratigraphy step. - The build button and step 4 name the workflow.
1 of 3 tasks
The parametric faults and the fault abutting relationships were built only in update_fault_features, which runs only with "map". Build them in the constraints mode too. The test for a mode change of an empty model used the fixture, which has a foliation in the model, so the model was not empty. Use a new manager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 6.1 of the usability plan. With "Interpolate surfaces from constraints", the build now uses only the features that the user adds in step 4. The column, the contacts and the fault traces keep their data, but the model does not use it.
update_modelandrefresh_feature_dataskip the column and the fault traces. A column or topology change does not make the model stale. A mode change makes a built model stale.sync_extra_constraintsare empty. When the user changes back to "map", the map layers are read again.Tests
tests/unitpass (233).tests/qgis/test_workflow_mode_model.py. I could not run them locally (no QGIS Python), so they need the QGIS test job.This PR is stacked on #136.